fix: remove hardcoded /bin/sh for external editor on Windows#246
Open
jiang1997 wants to merge 1 commit into
Open
fix: remove hardcoded /bin/sh for external editor on Windows#246jiang1997 wants to merge 1 commit into
jiang1997 wants to merge 1 commit into
Conversation
Run the external editor through Node's platform shell instead of spawning /bin/sh directly. Quote the appended temp file path per platform so Ctrl+G works on Windows while preserving shell-style editor commands.
🦋 Changeset detectedLatest commit: b499459 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #238
Problem
Ctrl+G opens the configured external editor by spawning
/bin/sh -c "<editor> <tempfile>". This fails on Windows because/bin/shis not available, so Windows users cannot use the external editor flow.What changed
Run the external editor command through Node's platform shell instead of spawning
/bin/shdirectly. Quote the appended temp file path per platform so paths with spaces survive shell parsing.This preserves existing shell-style editor commands such as
code --waitandnvim +set ft=markdown, while allowing Windows to use its platform shell for the external editor flow.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.